-
Notifications
You must be signed in to change notification settings - Fork 21
Add reproducible builds #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SozinM
wants to merge
9
commits into
main
Choose a base branch
from
msozin/make-release-reproducible
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+113
β3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6fae7bb
to
cb9b9c8
Compare
alexhulbert
requested changes
Aug 13, 2025
alexhulbert
approved these changes
Aug 13, 2025
@SozinM manually requesting you to review since Github won't let me request your review on your own PR |
SozinM
commented
Aug 14, 2025
SozinM
commented
Aug 14, 2025
SozinM
commented
Aug 14, 2025
β¦msozin/make-release-reproducible
12bae3d
to
4a23f25
Compare
d5d231e
to
094d496
Compare
094d496
to
f58cb33
Compare
Should be good now! @SozinM can you give it another check over? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
From reth
https://github.com/paradigmxyz/reth/blob/f30016019d592e36b31b48feb8adf3292c04b626/Makefile#L83
π‘ Motivation and Context
β I have completed the following steps:
make lint
make test